[llvm-commits] [llvm] r80892 - in /llvm/trunk/lib/Target/X86: X86Subtarget.cpp X86Subtarget.h

Daniel Dunbar daniel at zuster.org
Wed Sep 2 22:47:34 PDT 2009


Author: ddunbar
Date: Thu Sep  3 00:47:34 2009
New Revision: 80892

URL: http://llvm.org/viewvc/llvm-project?rev=80892&view=rev
Log:
Make these functions static and local.

Modified:
    llvm/trunk/lib/Target/X86/X86Subtarget.cpp
    llvm/trunk/lib/Target/X86/X86Subtarget.h

Modified: llvm/trunk/lib/Target/X86/X86Subtarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=80892&r1=80891&r2=80892&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.cpp Thu Sep  3 00:47:34 2009
@@ -158,9 +158,8 @@
 
 /// GetCpuIDAndInfo - Execute the specified cpuid and return the 4 values in the
 /// specified arguments.  If we can't run cpuid on the host, return true.
-bool
-X86Subtarget::GetCpuIDAndInfo(unsigned value, unsigned *rEAX,
-                              unsigned *rEBX, unsigned *rECX, unsigned *rEDX) {
+static bool GetCpuIDAndInfo(unsigned value, unsigned *rEAX,
+                            unsigned *rEBX, unsigned *rECX, unsigned *rEDX) {
 #if defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)
   #if defined(__GNUC__)
     // gcc doesn't know cpuid would clobber ebx/rbx. Preseve it manually.
@@ -240,7 +239,7 @@
   if ((EDX >> 23) & 1) X86SSELevel = MMX;
   if ((EDX >> 25) & 1) X86SSELevel = SSE1;
   if ((EDX >> 26) & 1) X86SSELevel = SSE2;
-  if (ECX & 0x1)         X86SSELevel = SSE3;
+  if (ECX & 0x1)       X86SSELevel = SSE3;
   if ((ECX >> 9)  & 1) X86SSELevel = SSSE3;
   if ((ECX >> 19) & 1) X86SSELevel = SSE41;
   if ((ECX >> 20) & 1) X86SSELevel = SSE42;
@@ -265,7 +264,7 @@
   }
 }
 
-const char *X86Subtarget::GetCurrentX86CPU() {
+static const char *GetCurrentX86CPU() {
   unsigned EAX = 0, EBX = 0, ECX = 0, EDX = 0;
   if (GetCpuIDAndInfo(0x1, &EAX, &EBX, &ECX, &EDX))
     return "generic";

Modified: llvm/trunk/lib/Target/X86/X86Subtarget.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.h?rev=80892&r1=80891&r2=80892&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.h (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.h Thu Sep  3 00:47:34 2009
@@ -214,14 +214,6 @@
   /// indicating the number of scheduling cycles of backscheduling that
   /// should be attempted.
   unsigned getSpecialAddressLatency() const;
-
-private:
-  /// GetCpuIDAndInfo - Execute the specified cpuid and return the 4 values in
-  /// the specified arguments.  If we can't run cpuid on the host, return true.
-  bool GetCpuIDAndInfo(unsigned value, unsigned *rEAX, unsigned *rEBX,
-                       unsigned *rECX, unsigned *rEDX);
-
-  const char *GetCurrentX86CPU();
 };
 
 } // End llvm namespace





More information about the llvm-commits mailing list