[llvm-commits] [llvm] r80406 - in /llvm/trunk: docs/ include/llvm/ include/llvm/Analysis/ include/llvm/CodeGen/ include/llvm/Support/ lib/Analysis/ lib/AsmParser/ lib/Bitcode/Reader/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/CodeGen/SelectionDAG/

[Devang Patel]

2009/9/2 Török Edwin <edwintorok at gmail.com>:
> On 2009-08-29 02:24, Devang Patel wrote:
>> Author: dpatel
>> Date: Fri Aug 28 18:24:31 2009
>> New Revision: 80406
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=80406&view=rev
>> Log:
>> Reapply 79977.
>> Use MDNodes to encode debug info in llvm IR.
>>
>> Removed:
>>     llvm/trunk/test/DebugInfo/2008-11-06-Mem2Reg.ll
>>     llvm/trunk/test/DebugInfo/2008-11-19-InstCombine.ll
>>     llvm/trunk/test/DebugInfo/2009-01-28-ArrayType.ll
>>     llvm/trunk/test/DebugInfo/2009-01-29-HeaderLocation.ll
>>     llvm/trunk/test/DebugInfo/2009-01-29-MethodDeclaration.ll
>>     llvm/trunk/test/DebugInfo/2009-01-30-Method.ll
>>     llvm/trunk/test/DebugInfo/2009-02-23-InstCombine.ll
>>     llvm/trunk/test/DebugInfo/2009-03-02-sink.ll
>>     llvm/trunk/test/DebugInfo/dataOnly.ll
>>     llvm/trunk/test/DebugInfo/forwardDecl.ll
>>     llvm/trunk/test/DebugInfo/printdbginfo.ll
>>     llvm/trunk/test/DebugInfo/printdbginfo2.ll
>>
>
> Hi Devang,
>
> This commit removed the test for -print-dbginfo, and broke
> DbgStopPointInst->getFileName():

sorry about the breakage.

> entry:; (opt:
> /home/edwin/llvm-git/llvm/include/llvm/Support/Casting.h:199: typename
> llvm::cast_retty<To, From>::ret_type llvm::cast(const Y&) [with X =
> llvm::GlobalVariable, Y = llvm::MDNode*]: Assertion `isa<X>(Val) &&
> "cast<Ty>() argument of incompatible type!"' failed.
>
> I fixed this in r80788, please check if my fix is the correct one.

Thanks!

>
> Why were the tests removed, doesn't llvm-as autoupgrade the old
> debuginfo to MDNodes?
>

It does not. We just ignore debug info from old IR.
-
Devang