[llvm-commits] cleanup patch for TwoAddressInstructionPass

[Evan Cheng]

Hi Bob,

It looks pretty good to me. The only thing that bugs me is the extra  
blank lines. :-)

+          regB = regC;
+
+        } else if (TID.isConvertibleTo3Addr()) {
+

If it passes tests, please commit. Thanks.

Evan

On Sep 1, 2009, at 5:49 PM, Bob Wilson wrote:

> Evan,
>
> I started looking at the overhaul you suggested.  It is not done  
> yet, but I have tried to clean up the existing optimizations for the  
> case where a source register is only tied to one destination.  There  
> was a lot of redundancy in this code, not to mention the goto.  I've  
> rearranged it to try to clean that up.  It is not exactly identical  
> in behavior to the previous code, though.  Can you review this  
> before I commit it?  I think you have a better understanding of all  
> the issues in this code than I do.
>
> Thanks.
> <tworeg-cleanup.patch>