[llvm-commits] [llvm] r80671 - /llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp

[Duncan Sands]

Author: baldrick
Date: Tue Sep  1 10:13:02 2009
New Revision: 80671

URL: http://llvm.org/viewvc/llvm-project?rev=80671&view=rev
Log:
Do not manipulate invalid iterators.  This fixes the
llvm-gcc build when expensive checking is turned on.

Modified:
    llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp

Modified: llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp?rev=80671&r1=80670&r2=80671&view=diff

==============================================================================
--- llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp (original)
+++ llvm/trunk/lib/Analysis/IPA/CallGraphSCCPass.cpp Tue Sep  1 10:13:02 2009
@@ -143,11 +143,16 @@
     
     // Walk the function body looking for call sites.  Sync up the call sites in
     // CGN with those actually in the function.
-    
+
     // Get the set of call sites currently in the function.
-    for (CallGraphNode::iterator I = CGN->begin(), E = CGN->end(); I != E; ++I){
+    bool isLast = CGN->empty();
+    for (CallGraphNode::iterator I = CGN->begin(), E = CGN->end(), N; !isLast;){
+      // Take care not to use singular iterators.
+      N = I + 1;
+      isLast = N == E;
+
       // If this call site is null, then the function pass deleted the call
-      // entirely and the WeakVH nulled it out.  
+      // entirely and the WeakVH nulled it out.
       if (I->first == 0 ||
           // If we've already seen this call site, then the FunctionPass RAUW'd
           // one call with another, which resulted in two "uses" in the edge
@@ -161,15 +166,15 @@
         // Just remove the edge from the set of callees.
         CGN->removeCallEdge(I);
         E = CGN->end();
-        --I;
         continue;
       }
-      
+
       assert(!CallSites.count(I->first) &&
              "Call site occurs in node multiple times");
       CallSites.insert(std::make_pair(I->first, I->second));
+      I = N;
     }
-    
+
     // Loop over all of the instructions in the function, getting the callsites.
     for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB)
       for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I) {