[llvm-commits] [llvm] r80481 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

[Bill Wendling]

On Aug 29, 2009, at 10:55 PM, Chris Lattner wrote:

> Author: lattner
> Date: Sun Aug 30 00:55:36 2009
> New Revision: 80481
>
> URL: http://llvm.org/viewvc/llvm-project?rev=80481&view=rev
> Log:
> refactor instcombine's worklist processing stuff out to its own class.
>
> Modified:
>    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
>
> Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=80481&r1=80480&r2=80481&view=diff
>
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp  
> (original)
> +++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Sun  
> Aug 30 00:55:36 2009
> @@ -74,30 +74,27 @@
> STATISTIC(NumSunkInst , "Number of instructions sunk");
>
> namespace {
> -  class VISIBILITY_HIDDEN InstCombiner
> -    : public FunctionPass,
> -      public InstVisitor<InstCombiner, Instruction*> {
> -    // Worklist of all of the instructions that need to be  
> simplified.
> +  /// InstCombineWorklist - This is the worklist management logic for
> +  /// InstCombine.
> +  class InstCombineWorklist {

Would it make sense for this class to be marked 'VISIBILITY_HIDDEN' as  
well?

-bw