[llvm-commits] [PATCH] Preparation for Optimal Edge Profiling: Add calculation of maximum spanning tree.

Daniel Dunbar daniel at zuster.org
Fri Aug 28 09:00:45 PDT 2009


On Fri, Aug 28, 2009 at 4:09 AM, Andreas
Neustifter<e0325716 at student.tuwien.ac.at> wrote:
> I moved the class to lib/Trans../Instr.. and implemented EquivalenceClasses.

Nice!

>>> It isn't necessary, but I think this code might be simpler and easier
>>> to read if it was just a generic implementation of Kruskal's
>>> algorithm, which the Optimal Edge Profiling could manage its own
>>> instantiation of. Then it would make sense to drop it in ADT/
>>
>> I am not sure if I manage to work this out but I will try.
>
> I did not succeed immediately, so I will check it in and make these
> changes later.

Ok! For stuff private to the implementation its fine to "be
incremental" and improve it later...

 - Daniel



More information about the llvm-commits mailing list