[llvm-commits] [llvm] r80076 - /llvm/trunk/tools/llvm-prof/llvm-prof.cpp

[Chris Lattner]

On Aug 26, 2009, at 1:02 PM, Daniel Dunbar wrote:
> On Wed, Aug 26, 2009 at 8:43 AM, Chris Lattner<clattner at apple.com>  
> wrote:
>> On Aug 26, 2009, at 2:05 AM, Andreas Neustifter wrote:
>>> Author: astifter
>>> Date: Wed Aug 26 04:05:21 2009
>>> New Revision: 80076
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=80076&view=rev
>>> Log:
>>> Changed std::cout to outs(), retaining formating.
>>
>> Can the <iostream> #include go away?
>>
>> Thanks for doing this!
>>
>> Is there any chance llvm-prof can stop using AsmAnnotationWriter?
>
> Hi Chris,
>
> Please don't remove AsmAnnotationWriter (the class, not its
> incarnation in llvm-prof)! :)
>
> Or at least, do you have a good way to implement a Instruction to .ll
> line # mapping without it?
>
> Does removing the annotation writer have some major pros?

The main objection that I have to it is that it is an extension  
mechanism that is only used by llvm-prof that makes the asmwriter  
(slightly) more complicated.  I think it would be better to refactor  
the asmwriter so that it can be driven in a more fine grained way,  
which would then allow clients to intersperse whatever information  
they want into it.  This is very similar to the "live interval index"  
stuff that David Greene wanted on the MachineFunction printer.

-Chris