[llvm-commits] [llvm] r79958 - in /llvm/trunk: lib/Target/CellSPU/SPUISelDAGToDAG.cpp test/CodeGen/CellSPU/loads.ll

[Scott Michel]

Author: pingbak
Date: Mon Aug 24 18:57:35 2009
New Revision: 79958

URL: http://llvm.org/viewvc/llvm-project?rev=79958&view=rev
Log:
- Remove SelectSEXTi128 from SPUISelDAGToDAG.cpp, evidently, this is redundant
  code, according to Anton (I'm not totally convinced, but we can always
  resurrect patches if we need to do so.)
- Start moving CellSPU's tests to prefer FileCheck.


Modified:
    llvm/trunk/lib/Target/CellSPU/SPUISelDAGToDAG.cpp
    llvm/trunk/test/CodeGen/CellSPU/loads.ll

Modified: llvm/trunk/lib/Target/CellSPU/SPUISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/CellSPU/SPUISelDAGToDAG.cpp?rev=79958&r1=79957&r2=79958&view=diff

==============================================================================
--- llvm/trunk/lib/Target/CellSPU/SPUISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/CellSPU/SPUISelDAGToDAG.cpp Mon Aug 24 18:57:35 2009
@@ -322,9 +322,6 @@
     /// target-specific node if it hasn't already been changed.
     SDNode *Select(SDValue Op);
 
-    //! Emit the instruction sequence for i128 sext
-    SDNode *SelectSEXTi128(SDValue &Op, EVT OpVT);
-
     //! Emit the instruction sequence for i64 shl
     SDNode *SelectSHLi64(SDValue &Op, EVT OpVT);
 
@@ -836,10 +833,6 @@
         }
       }
     }
-  } else if (Opc == ISD::SIGN_EXTEND) {
-    if (OpVT == MVT::i128) {
-      return SelectSEXTi128(Op, OpVT);
-    }
   } else if (Opc == ISD::SHL) {
     if (OpVT == MVT::i64) {
       return SelectSHLi64(Op, OpVT);
@@ -964,58 +957,6 @@
 }
 
 /*!
- * Emit the instruction sequence for i64 -> i128 sign extend. The basic
- * algorithm is to duplicate the sign bit using rotmai to generate at
- * least one byte full of sign bits. Then propagate the "sign-byte" into
- * theleftmost words and the i64 into the rightmost words using shufb.
- *
- * @param Op The sext operand
- * @param OpVT The type to extend to
- * @return The SDNode with the entire instruction sequence
- */
-SDNode *
-SPUDAGToDAGISel::SelectSEXTi128(SDValue &Op, EVT OpVT)
-{
-  DebugLoc dl = Op.getDebugLoc();
-
-  // Type to extend from
-  SDValue Op0 = Op.getOperand(0);
-  EVT Op0VT = Op0.getValueType();
-
-  assert((OpVT == MVT::i128 && Op0VT == MVT::i64) &&
-         "LowerSIGN_EXTEND: input and/or output operand have wrong size");
-
-  // Create shuffle mask
-  unsigned mask1 = 0x10101010; // byte  0 -  3 and 4 - 7
-  unsigned mask2 = 0x01020304; // byte  8 - 11
-  unsigned mask3 = 0x05060708; // byte 12 - 15
-  SDValue shufMask = CurDAG->getNode(ISD::BUILD_VECTOR, dl, MVT::v4i32,
-                             CurDAG->getConstant(mask1, MVT::i32),
-                             CurDAG->getConstant(mask1, MVT::i32),
-                             CurDAG->getConstant(mask2, MVT::i32),
-                             CurDAG->getConstant(mask3, MVT::i32));
-  SDNode *shufMaskLoad = emitBuildVector(shufMask);
-
-  // Word wise arithmetic right shift to generate at least one byte
-  // that contains sign bits.
-  SDNode *PromoteScalar = SelectCode(CurDAG->getNode(SPUISD::PREFSLOT2VEC, dl,
-                                                     MVT::v2i64, Op0, Op0));
-  SDNode *sraVal = SelectCode(CurDAG->getNode(ISD::SRA, dl, MVT::v2i64,
-                                         SDValue(PromoteScalar, 0),
-                                         CurDAG->getConstant(31, MVT::i32)));
-
-  // Shuffle bytes - Copy the sign bits into the upper 64 bits
-  // and the input value into the lower 64 bits.
-  SDNode *extShuffle = SelectCode(CurDAG->getNode(SPUISD::SHUFB, dl,
-                                                  MVT::v2i64, Op0,
-                                                  SDValue(sraVal, 0),
-                                                  SDValue(shufMaskLoad, 0)));
-
-  return SelectCode(CurDAG->getNode(ISD::BIT_CONVERT, dl, MVT::i128,
-                                    SDValue(extShuffle, 0)));
-}
-
-/*!
  * Emit the instruction sequence for i64 left shifts. The basic algorithm
  * is to fill the bottom two word slots with zeros so that zeros are shifted
  * in as the entire quadword is shifted left.

Modified: llvm/trunk/test/CodeGen/CellSPU/loads.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/loads.ll?rev=79958&r1=79957&r2=79958&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/CellSPU/loads.ll (original)
+++ llvm/trunk/test/CodeGen/CellSPU/loads.ll Mon Aug 24 18:57:35 2009
@@ -1,6 +1,4 @@
-; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
-; RUN: grep {lqd.*0(\$3)}   %t1.s | count 1
-; RUN: grep {lqd.*16(\$3)}  %t1.s | count 1
+; RUN: llvm-as -o - %s | llc -march=cellspu | FileCheck %s
 
 ; ModuleID = 'loads.bc'
 target datalayout = "E-p:32:32:128-f64:64:128-f32:32:128-i64:32:128-i32:32:128-i16:16:128-i8:8:128-i1:8:128-a0:0:128-v128:128:128-s0:128:128"
@@ -10,11 +8,13 @@
 entry:
 	%tmp1 = load <4 x float>* %a
 	ret <4 x float> %tmp1
+; CHECK:	lqd	$3, 0($3)
 }
 
 define <4 x float> @load_v4f32_2(<4 x float>* %a) nounwind readonly {
 entry:
-	%arrayidx = getelementptr <4 x float>* %a, i32 1		; <<4 x float>*> [#uses=1]
-	%tmp1 = load <4 x float>* %arrayidx		; <<4 x float>> [#uses=1]
+	%arrayidx = getelementptr <4 x float>* %a, i32 1
+	%tmp1 = load <4 x float>* %arrayidx
 	ret <4 x float> %tmp1
+; CHECK:	lqd	$3, 16($3)
 }