[llvm-commits] [llvm] r79631 - in /llvm/trunk/lib/Target/PIC16: AsmPrinter/PIC16AsmPrinter.cpp AsmPrinter/PIC16AsmPrinter.h MCSectionPIC16.h PIC16.h PIC16PAN.h PIC16Passes/Makefile PIC16Passes/PIC16FrameOverlay.cpp PIC16Passes/PIC16FrameOverlay.h PIC16TargetObjectFile.cpp PIC16TargetObjectFile.h

[Julien Lerouge]

On Sat, Aug 22, 2009 at 12:42:41AM +0530, Sanjiv Gupta wrote:
> Chris Lattner wrote:
> >
> > On Aug 21, 2009, at 8:22 AM, Sanjiv Gupta wrote:
> >
> >> Author: sgupta
> >> Date: Fri Aug 21 10:22:33 2009
> >> New Revision: 79631
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=79631&view=rev
> >> Log:
> >> Add a pass to do call graph analyis to overlay the autos and frame 
> >> sections of
> >> leaf functions. This pass will be extended to color other nodes of 
> >> the call tree
> >> as well in future.
> >
> > Sanjiv, this commit, r79562 and r79563 are not the right way to tackle 
> > this problem, and are coming in the day of the release branch.  Please 
> > revert them and propose patches for these on llvmdev.
> >
> > -Chris
> >
> Chris,
> Both these passes are currently optional (loadable modules) and are 
> entirely pic16 specific. They are just the framework on which we intend 
> to build upon and currently do not run by default. Do you still feel 
> that these need to reverted back.
> 
> - Sanjiv

It's actually breaking the MingW build (probably because of the loadable
modules). Could it be disabled by default ? I don't think loadable
modules are possible on MingW currently.

make[4]: Leaving directory `/c/cygwin/home/jlerouge/buildbot/llvm/llvm-build/lib/Target/PIC16/PIC16Passes'
c:/cygwin/home/jlerouge/buildbot/llvm/llvm-build/lib/Target/PIC16/PIC16Passes/Release/PIC16CallGraph.o:PIC16CallGraph.cpp:(.text+0x6): undefined reference to `llvm::errs()'
....
c:/cygwin/home/jleroug/llvm/llvm-build/lib/Target/PIC16/PIC16Passes/Release/PIC16CallC16CallGraph.cpp:(.text$_ZN118_GLOBAL__N_c__cygwin_home_jlerougasses_PIC16CallGraph.cpp_3F6EE7DC_0E329F0D14PIC16CallGraphD0Ev[ namespace)::PIC16CallGraph::~PIC16CallGraph()]+0x12): undefinee to `llvm::ModulePass::~ModulePass()'
collect2: ld returned 1 s
make[4]: *** [/c/cygwin/home/jlerouge/buildbot/llvm/llvm-buil/PIC16Passes.dll] Error 1
make[3]: *** [all] Error 1

Thanks,
Julien

-- 
Julien Lerouge
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com