[llvm-commits] [llvm] r79631 - in /llvm/trunk/lib/Target/PIC16:AsmPrinter/PIC16AsmPrinter.cpp AsmPrinter/PIC16AsmPrinter.hMCSectionPIC16.h PIC16.h PIC16PAN.h PIC16Passes/MakefilePIC16Passes/PIC16FrameOverlay.cppPIC16Passes/PIC16FrameOverlay.h PIC16Tar

[Alireza.Moshtaghi at microchip.com]

> > Add a pass to do call graph analyis to overlay the autos and frame
> > sections of
> > leaf functions. This pass will be extended to color other nodes of
> > the call tree
> > as well in future.
> 
> Sanjiv, this commit, r79562 and r79563 are not the right way to tackle
> this problem, and are coming in the day of the release branch.  Please
> revert them and propose patches for these on llvmdev.

Hi Chris

The reason why we are doing these in backend is that cloning a function
is base on which functions call it and of course in frontend we don't
have the view of the entire call graph. We'll be happy to revert these,
but I would like to know exactly why in your view. 
With our current design wrto accessing auto variables, and how they work
in the cloned function, this is the best that we can do. Although, it is
likely that we change the design after 2.6 but we would prefer to get as
much of the functionality in 2.6 as possible because we want to base an
internal release of PIC16 compiler on llvm 2.6 

-Ali