[llvm-commits] [llvm] r79484 - in /llvm/trunk: lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp test/CodeGen/X86/2009-08-19-inline-asm-a-modifier.ll

[Dale Johannesen]

On Aug 19, 2009, at 4:06 PMPDT, Chris Lattner wrote:
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79484&view=rev
>> Log:
>> Handle 'a' modifier in X86 asms.  PR 4742.
>
> hi Dale,
>
> Any reason not to make this be a FileCheck style test?  If you do  
> that, you can merge it together with other tests as well.

It uses a regexp.  FileCheck doesn't support those, right?

> Also, no reason to use 'else if' after a return, just use 'if'.

All right, I suppose, to me it reads much better this way, but it's  
not really important.