[llvm-commits] REQUIRES_FP in Makefile.rules

[Nicolas Geoffray]

Eric Christopher wrote:
>
> On Aug 18, 2009, at 3:36 PM, Nicolas Geoffray wrote:
>
>> Hi all,
>>
>> I'd like to add a new option (REQUIRES_FP) in Makefile.rules to 
>> disable the fomit-frame-pointer option when building. Here's the 
>> patch attached. I need this because vmkit needs to walk the stack of 
>> a thread, and functions from llvm may be in it.
>>
>
> Quick question: As in things that are currently being compiled? 

No, C++ llvm functions that are in the llvm codebase. Like functions 
from JITEmitter and stuff.

> Seems a bit odd that it's not executing code that's being walked up 
> but rather the compiler itself.

When I'm using the JIT, functions from the llvm code base may be executing.

>
>> I don't know what's the policy for the Makefiles in general. Is it OK 
>> to apply that change?
>
> Sure if it's really necessary :)

Great!

Nicolas

>
> -eric