[llvm-commits] [llvm] r78707 - in /llvm/trunk: include/llvm/Constants.h include/llvm/InstrTypes.h include/llvm/Support/ConstantFolder.h include/llvm/Support/IRBuilder.h include/llvm/Support/NoFolder.h include/llvm/Support/TargetFolder.h lib/VMCore/Constants.cpp

Duncan Sands baldrick at free.fr
Mon Aug 17 05:25:41 PDT 2009


Hi Dan,

> +  /// CreateNSWAdd - Create an Add operator with the NSW flag set.
> +  ///
> +  static BinaryOperator *CreateNSWAdd(Value *V1, Value *V2,
> +                                      const Twine &Name = "") {
> +    BinaryOperator *BO = CreateAdd(V1, V2, Name);
> +    cast<AddOperator>(BO)->setHasNoSignedOverflow(true);
> +    return BO;
> +  }

the names NSW and NoSignedOverflow are kind of inconsistent.  Shouldn't
NSW be NSO, or NoSignedOverflow be NoSignedWraparound?

Ciao,

Duncan.



More information about the llvm-commits mailing list