[llvm-commits] [llvm] r78840 - /llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp

[Alireza.Moshtaghi at microchip.com]

Thank you Lang, it worked and we are not seeing the extra spills anymore.
Will let you know if we find new opportunities for optimization.

Regards
Ali

> -----Original Message-----
> From: Lang Hames [mailto:lhames at gmail.com]
> Sent: Wednesday, August 12, 2009 2:13 PM
> To: llvm-commits at cs.uiuc.edu; Alireza Moshtaghi - C13012; Sanjiv Kumar
> Gupta - I00171
> Subject: [llvm-commits] [llvm] r78840 -
> /llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
> 
> Hi Ali, Sanjiv,
> 
> Looks like the PBQP allocation quality issue was due to me leaving the
> coalescer out of the pass requirements for PBQP. This has been fixed.
> 
> I'll be tweaking PBQP a bit over the coming months to try to further
> improve allocation quality. Any feedback on how it impacts your code
> would be most welcome.
> 
> Cheers,
> Lang.
> 
> On Wed, Aug 12, 2009 at 2:04 PM, Lang Hames<lhames at gmail.com> wrote:
> > Author: lhames
> > Date: Wed Aug 12 16:04:53 2009
> > New Revision: 78840
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=78840&view=rev
> > Log:
> > Added RegisterCoalescer to required passes for PBQP.
> >
> > Modified:
> >    llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
> >
> > Modified: llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
> > URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp?rev=78840&r1=78839&r2=7884
> 0&view=diff
> >
> >
> ==========================================================================
> ====
> > --- llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp (original)
> > +++ llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp Wed Aug 12 16:04:53 2009
> > @@ -82,6 +82,7 @@
> >     virtual void getAnalysisUsage(AnalysisUsage &au) const {
> >       au.addRequired<LiveIntervals>();
> >       //au.addRequiredID(SplitCriticalEdgesID);
> > +      au.addRequired<RegisterCoalescer>();
> >       au.addRequired<LiveStacks>();
> >       au.addPreserved<LiveStacks>();
> >       au.addRequired<MachineLoopInfo>();
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >