[llvm-commits] [llvm] r78567 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h include/llvm/Support/IOManip.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp

[Chris Lattner]

On Aug 11, 2009, at 3:45 PM, Dan Gohman wrote:

>
> On Aug 11, 2009, at 12:59 PM, David A. Greene wrote:
>
>
>> On Tuesday 11 August 2009 12:22, Chris Lattner wrote:
>>
>>
>>>> +      if (loop->empty()) {
>>>>
>>>
>>>
>>> I don't think that loops can be empty, they have to at least have a
>>>
>>> header.  I don't know why MachineLoop has an empty() predicate.
>
> empty() doesn't mean the loop has no blocks; it means the loop
> has no sub-loops.
>
>>>
>>
>> I'm going to leave this here for now.  When empty() goes away we can
>> fix it.
>
> The code behaves as intended right now. I wouldn't argue if someone
> wanted
> to rename begin() and friends to subloops_begin() etc. to make it more
> explicit though.

Aha, ok.

-Chris