[llvm-commits] [llvm] r78628 - /llvm/trunk/autoconf/configure.ac

[Chris Lattner]

On Aug 10, 2009, at 5:59 PM, Gabor Greif wrote:

> Author: ggreif
> Date: Mon Aug 10 19:59:39 2009
> New Revision: 78628
>
> URL: http://llvm.org/viewvc/llvm-project?rev=78628&view=rev
> Log:
> Lay the groundwork for my upcoming ilist sentinel shrinking patch
> by defining a LLVM_COMPACT_SENTINELS symbol to 0 or 1 in config.h.

Gabor, it is usually a bad idea to make major ABI changes like this  
based on build settings like ENABLE_OPTIMIZED and DISABLE_ASSERTIONS.   
Why do you need this?

-Chris

>
> I'm asking for 3 favors:
> - may an autofoo expert look at this and suggest improvements?
> - may a cmake expert suggest analogous functionality for config.h?
> - may somebody with the right autofoo mix regenerate configure?  
> (mine is too new)
>
> Thanks!
> --This line, and those below, will be ignored--
>
> M    configure.ac
>
> Modified:
>    llvm/trunk/autoconf/configure.ac
>
> Modified: llvm/trunk/autoconf/configure.ac
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=78628&r1=78627&r2=78628&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/autoconf/configure.ac (original)
> +++ llvm/trunk/autoconf/configure.ac Mon Aug 10 19:59:39 2009
> @@ -312,6 +312,17 @@
>   AC_SUBST(DISABLE_ASSERTIONS,[[DISABLE_ASSERTIONS=1]])
> fi
>
> +dnl LLVM_COMPACT_SENTINELS : can be used to shrink ilist's end  
> iterators and disable certain checks on them:
> +if test ${ENABLE_OPTIMIZED},${DISABLE_ASSERTIONS} =  
> "ENABLE_OPTIMIZED=1,DISABLE_ASSERTIONS=1" ; then
> +  AC_SUBST(LLVM_COMPACT_SENTINELS,[1])
> +else
> +  AC_SUBST(LLVM_COMPACT_SENTINELS,[0])
> +fi
> +
> +AC_DEFINE_UNQUOTED([LLVM_COMPACT_SENTINELS],$LLVM_COMPACT_SENTINELS,
> +                   [Define to 1 for ilist sentinel compaction])
> +
> +
> dnl --enable-expensive-checks : check whether they want to turn on  
> expensive debug checks:
> AC_ARG_ENABLE(expensive-checks,AS_HELP_STRING(
>   --enable-expensive-checks,[Compile with expensive debug checks  
> enabled (default is NO)]),, enableval="no")
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits