[llvm-commits] [llvm] r78444 - in /llvm/trunk: lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp lib/Target/MSP430/MSP430AsmPrinter.cpp lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp lib/Target/XCore/XCoreAsmPrinter.cpp utils/TableGen/AsmWriterEmitter.cpp

[Chris Lattner]

Author: lattner
Date: Fri Aug  7 19:05:42 2009
New Revision: 78444

URL: http://llvm.org/viewvc/llvm-project?rev=78444&view=rev
Log:
don't check the result of printInstruction anymore.

Modified:
    llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp
    llvm/trunk/lib/Target/MSP430/MSP430AsmPrinter.cpp
    llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
    llvm/trunk/lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp
    llvm/trunk/lib/Target/XCore/XCoreAsmPrinter.cpp
    llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

Modified: llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp Fri Aug  7 19:05:42 2009
@@ -175,9 +175,7 @@
          II != E; ++II) {
       // Print the assembly for the instruction.
       ++EmittedInsts;
-      if (!printInstruction(II)) {
-        llvm_unreachable("Unhandled instruction in asm writer!");
-      }
+      printInstruction(II);
     }
   }
 

Modified: llvm/trunk/lib/Target/MSP430/MSP430AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/MSP430/MSP430AsmPrinter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/lib/Target/MSP430/MSP430AsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/MSP430/MSP430AsmPrinter.cpp Fri Aug  7 19:05:42 2009
@@ -142,10 +142,7 @@
   ++EmittedInsts;
 
   // Call the autogenerated instruction printer routines.
-  if (printInstruction(MI))
-    return;
-
-  llvm_unreachable("Should not happen");
+  printInstruction(MI);
 }
 
 void MSP430AsmPrinter::printOperand(const MachineInstr *MI, int OpNum,

Modified: llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp Fri Aug  7 19:05:42 2009
@@ -571,10 +571,7 @@
     }
   }
 
-  if (printInstruction(MI))
-    return; // Printer was automatically generated
-
-  llvm_unreachable("Unhandled instruction in asm writer!");
+  printInstruction(MI);
 }
 
 /// runOnMachineFunction - This uses the printMachineInstruction()

Modified: llvm/trunk/lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp Fri Aug  7 19:05:42 2009
@@ -152,10 +152,7 @@
   ++EmittedInsts;
 
   // Call the autogenerated instruction printer routines.
-  if (printInstruction(MI))
-    return;
-
-  llvm_unreachable("Unreachable!");
+  printInstruction(MI);
 }
 
 void SystemZAsmPrinter::printPCRelImmOperand(const MachineInstr *MI, int OpNum) {

Modified: llvm/trunk/lib/Target/XCore/XCoreAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreAsmPrinter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/lib/Target/XCore/XCoreAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/XCore/XCoreAsmPrinter.cpp Fri Aug  7 19:05:42 2009
@@ -364,10 +364,7 @@
     O << "\n";
     return;
   }
-  if (printInstruction(MI)) {
-    return;
-  }
-  llvm_unreachable("Unhandled instruction in asm writer!");
+  printInstruction(MI);
 }
 
 bool XCoreAsmPrinter::doInitialization(Module &M) {

Modified: llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp?rev=78444&r1=78443&r2=78444&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp Fri Aug  7 19:05:42 2009
@@ -113,12 +113,14 @@
 
 
 std::string AsmWriterOperand::getCode() const {
-  if (OperandType == isLiteralTextOperand)
+  if (OperandType == isLiteralTextOperand) {
+    if (Str.size() == 1)
+      return "O << '" + Str + "'; ";
     return "O << \"" + Str + "\"; ";
+  }
 
-  if (OperandType == isLiteralStatementOperand) {
+  if (OperandType == isLiteralStatementOperand)
     return Str;
-  }
 
   std::string Result = Str + "(MI";
   if (MIOpNo != ~0U)
@@ -448,9 +450,8 @@
     Command = "    " + Inst->Operands[0].getCode() + "\n";
 
     // If this is the last operand, emit a return.
-    if (Inst->Operands.size() == 1) {
+    if (Inst->Operands.size() == 1)
       Command += "    return true;\n";
-    }
     
     // Check to see if we already have 'Command' in UniqueOperandCommands.
     // If not, add it.