[llvm-commits] [llvm] r78097 - in /llvm/trunk: include/llvm/LLVMContext.h lib/VMCore/Constants.cpp lib/VMCore/LLVMContextImpl.cpp lib/VMCore/LLVMContextImpl.h

[Owen Anderson]

On Aug 4, 2009, at 9:11 PM, Chris Lattner wrote:

>
> On Aug 4, 2009, at 9:08 PM, Owen Anderson wrote:
>
>> On Aug 4, 2009, at 8:54 PM, Chris Lattner wrote:
>>> Fine, its implementation is private to vmcore, right?  Since it has
>>> to be forward declared in various headers, why not use class?
>>
>> Because MSVC is unhappy if you mix class/struct for the same type.
>
> I mean "why not use class consistently everywhere".  If LLVMContext is
> an internal implementation detail of VMCore, it is unfortunate that
> the tagtype has to be exposed at all.  You didn't answer the first q.

LLVMContext isn't internal to VMCore.  Clients need to be able to  
instantiate it.  LLVMContextImpl is private to VMCore, though.  I'm  
not clear on how that really impact the struct vs. class issue.

--Owen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090804/b1978180/attachment.bin>