[llvm-commits] [llvm] r78097 - in /llvm/trunk: include/llvm/LLVMContext.h lib/VMCore/Constants.cpp lib/VMCore/LLVMContextImpl.cpp lib/VMCore/LLVMContextImpl.h

Dan Gohman gohman at apple.com
Tue Aug 4 17:52:45 PDT 2009


On Aug 4, 2009, at 1:25 PM, Owen Anderson wrote:
> -class LLVMContext {
> +struct LLVMContext {
>   LLVMContextImpl* pImpl;

Hi Owen,

With the pImpl member being public, would it make sense to make
it const? It looks like it's never modified after its initialization
in the LLVMContext constructor. Alternatively, perhaps this could
be accessed with an accessor function.

Dan




More information about the llvm-commits mailing list