[llvm-commits] [PATCH] x86 code emitter improvements for object files

[Chris Lattner]

On Aug 3, 2009, at 3:25 PM, Bruno Cardoso Lopes wrote:

>>
>> For example.  It would be better to base the encoding on this flag  
>> than
>> checking things like Is64BitMode, IsPIC etc.
>
> Yes, that's the right way to go. I thought about that when I started  
> hacking the
> x86 code emitter, but the problem here is that I'm afraid of  
> breaking JIT stuff
> and lose the focus on the elf object code emission. I would be happy  
> to
> work on this clean up as a next step after elf is working, but I would
> prefer to
> apply this patch for now if that's ok for you. But it's your call  
> then.

Sure, makes sense to me.  Evan, are you ok with this patch?

-Chris