[llvm-commits] [llvm] r77960 - in /llvm/trunk/tools/lto: LTOCodeGenerator.cpp LTOCodeGenerator.h lto.cpp

[Devang Patel]

On Mon, Aug 3, 2009 at 12:16 AM, Nick Lewycky<nicholas at mxc.ca> wrote:
> Author: nicholas
> Date: Mon Aug  3 02:16:42 2009
> New Revision: 77960
>
> URL: http://llvm.org/viewvc/llvm-project?rev=77960&view=rev
> Log:
> Remove the GCC path from libLTO. This has been superceded by setAssemblerPath.
>
> Modified:
>    llvm/trunk/tools/lto/LTOCodeGenerator.cpp
>    llvm/trunk/tools/lto/LTOCodeGenerator.h
>    llvm/trunk/tools/lto/lto.cpp

What about lto_codegen_set_gcc_path() ? This is breaking (removing) C
api. Is it really necessary ?
-
Devang

>
> Modified: llvm/trunk/tools/lto/LTOCodeGenerator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/LTOCodeGenerator.cpp?rev=77960&r1=77959&r2=77960&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/lto/LTOCodeGenerator.cpp (original)
> +++ llvm/trunk/tools/lto/LTOCodeGenerator.cpp Mon Aug  3 02:16:42 2009
> @@ -76,7 +76,7 @@
>       _linker("LinkTimeOptimizer", "ld-temp.o", _context), _target(NULL),
>       _emitDwarfDebugInfo(false), _scopeRestrictionsDone(false),
>       _codeModel(LTO_CODEGEN_PIC_MODEL_DYNAMIC),
> -      _nativeObjectFile(NULL), _gccPath(NULL), _assemblerPath(NULL)
> +      _nativeObjectFile(NULL), _assemblerPath(NULL)
>  {
>     InitializeAllTargets();
>     InitializeAllAsmPrinters();
> @@ -126,13 +126,6 @@
>     return true;
>  }
>
> -void LTOCodeGenerator::setGccPath(const char* path)
> -{
> -    if ( _gccPath )
> -        delete _gccPath;
> -    _gccPath = new sys::Path(path);
> -}
> -
>  void LTOCodeGenerator::setAssemblerPath(const char* path)
>  {
>     if ( _assemblerPath )
> @@ -240,9 +233,6 @@
>     if ( _assemblerPath ) {
>         tool = *_assemblerPath;
>         needsCompilerOptions = false;
> -    }
> -    else if ( _gccPath ) {
> -        tool = *_gccPath;
>     } else {
>         // find compiler driver
>         tool = sys::Program::FindProgramByName("gcc");
>
> Modified: llvm/trunk/tools/lto/LTOCodeGenerator.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/LTOCodeGenerator.h?rev=77960&r1=77959&r2=77960&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/lto/LTOCodeGenerator.h (original)
> +++ llvm/trunk/tools/lto/LTOCodeGenerator.h Mon Aug  3 02:16:42 2009
> @@ -37,7 +37,6 @@
>     bool                addModule(class LTOModule*, std::string& errMsg);
>     bool                setDebugInfo(lto_debug_model, std::string& errMsg);
>     bool                setCodePICModel(lto_codegen_model, std::string& errMsg);
> -    void                setGccPath(const char* path);
>     void                setAssemblerPath(const char* path);
>     void                addMustPreserveSymbol(const char* sym);
>     bool                writeMergedModules(const char* path,
> @@ -63,7 +62,6 @@
>     StringSet                   _mustPreserveSymbols;
>     llvm::MemoryBuffer*         _nativeObjectFile;
>     std::vector<const char*>    _codegenOptions;
> -    llvm::sys::Path*            _gccPath;
>     llvm::sys::Path*            _assemblerPath;
>  };
>
>
> Modified: llvm/trunk/tools/lto/lto.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/lto.cpp?rev=77960&r1=77959&r2=77960&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/lto/lto.cpp (original)
> +++ llvm/trunk/tools/lto/lto.cpp Mon Aug  3 02:16:42 2009
> @@ -203,14 +203,6 @@
>  }
>
>  //
> -// sets the path to gcc
> -//
> -void lto_codegen_set_gcc_path(lto_code_gen_t cg, const char* path)
> -{
> -  cg->setGccPath(path);
> -}
> -
> -//
>  // sets the path to the assembler tool
>  //
>  void lto_codegen_set_assembler_path(lto_code_gen_t cg, const char* path)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
-
Devang