[llvm-commits] [llvm] r77499 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

[Chris Lattner]

On Jul 30, 2009, at 3:15 PM, David A. Greene wrote:

> On Thursday 30 July 2009 16:12, Chris Lattner wrote:
>
>>>  And
>>> not everyone wants this kind of padding.  A tab is a bit much for
>>> some folks
>>> and that's completely understandable.
>>
>> I'm not sure why someone wouldn't want this.  IF they don't want
>> indentation, they can just not use \t??
>
> This isn't indentation.  This is a patch to line up operands, like  
> this:
>
> opcode		op1,       op2,       [op3+op4]
> opcode		[op1+op2], op3,       op4
>
> Some people like the way things are now:
>
> opcode		op1, op2, [op3+op4]
> opcode		[op1+op2], op3, op4
>
> and won't like (with tabs):
>
> opcode		op1,	op2,	[op3+op4]
> opcode		[op1+op2],	op3,	op4
>
> So once we start putting tabs in .td files everyone is stuck with  
> them.

Too bad.  We can do the right thing for each target.  We don't have to  
support "indent" style rules for .s files, just pick one approach and  
be consistent.  Since you care them most about this, you can pick the  
rules.

-Chris