[llvm-commits] [llvm] r77499 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

Chris Lattner clattner at apple.com
Thu Jul 30 14:12:30 PDT 2009


On Jul 30, 2009, at 11:33 AM, David A. Greene wrote:

>>
>> Again, the groups.  Why are you doing this?  It appears that you are
>> trying to infer from the asmstring that you should not be padding
>> operands out when they are parenthesized or square-bracketized etc.
>
> Correct.
>
>> I don't see why tblgen should be having to infer this at this level.
>> Why not just make tblgen have an extremely trivial heuristic:
>>
>>   "If there is a \t in the asm string, pad it to a column".
>
> Because then we'd have to go modify all the .td files to insert \t.

But that's good: it means we can opt into it and migrate over time.   
I'm not interested in the least possible amount of work to get this  
feature, I'm interested in getting to the right design point.

I'm not saying you have to convert all the targets to use this.

>   And
> not everyone wants this kind of padding.  A tab is a bit much for  
> some folks
> and that's completely understandable.

I'm not sure why someone wouldn't want this.  IF they don't want  
indentation, they can just not use \t??

-Chris



More information about the llvm-commits mailing list