[llvm-commits] [llvm] r77597 - in /llvm/trunk: lib/VMCore/Metadata.cpp unittests/VMCore/MetadataTest.cpp

[Benjamin Kramer]

Author: d0k
Date: Thu Jul 30 10:35:55 2009
New Revision: 77597

URL: http://llvm.org/viewvc/llvm-project?rev=77597&view=rev
Log:
fix a unitialized pointer in NamedMDNode (and reenable unittest)

Modified:
    llvm/trunk/lib/VMCore/Metadata.cpp
    llvm/trunk/unittests/VMCore/MetadataTest.cpp

Modified: llvm/trunk/lib/VMCore/Metadata.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Metadata.cpp?rev=77597&r1=77596&r2=77597&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Metadata.cpp (original)
+++ llvm/trunk/lib/VMCore/Metadata.cpp Thu Jul 30 10:35:55 2009
@@ -35,7 +35,7 @@
 //
 NamedMDNode::NamedMDNode(const Twine &N, MetadataBase*const* MDs, 
                          unsigned NumMDs, Module *ParentModule)
-  : MetadataBase(Type::MetadataTy, Value::NamedMDNodeVal) {
+  : MetadataBase(Type::MetadataTy, Value::NamedMDNodeVal), Parent(0) {
   setName(N);
   for (unsigned i = 0; i != NumMDs; ++i)
     Node.push_back(WeakMetadataVH(MDs[i]));

Modified: llvm/trunk/unittests/VMCore/MetadataTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/VMCore/MetadataTest.cpp?rev=77597&r1=77596&r2=77597&view=diff

==============================================================================
--- llvm/trunk/unittests/VMCore/MetadataTest.cpp (original)
+++ llvm/trunk/unittests/VMCore/MetadataTest.cpp Thu Jul 30 10:35:55 2009
@@ -119,8 +119,6 @@
   EXPECT_STREQ("!0 = metadata !{null}\n", oss.str().c_str());
 }
 
-  // FIXME: Disabled, this crashes on linux.
-#if 0
 TEST(NamedMDNodeTest, Search) {
   Constant *C = ConstantInt::get(Type::Int32Ty, 1);
   Constant *C2 = ConstantInt::get(Type::Int32Ty, 2);
@@ -141,5 +139,4 @@
                "!1 = metadata !{i32 2}\n",
                oss.str().c_str());
 }
-#endif
 }