[llvm-commits] [llvm] r77397 - in /llvm/trunk: include/llvm/Support/FormattedStream.h lib/Support/FormattedStream.cpp

[Daniel Dunbar]

On Wed, Jul 29, 2009 at 9:52 AM, David Greene<dag at cray.com> wrote:
> I'm trying to get us back to where we were.  I think I have it and am
> running tests now.  I will be reverting Evan's revert after making sure
> I don't see a problem.  But as I said, that's no guarantee there won't
> be some kind of problem I can't see.

Ok. When reenabling the formatted ostream for the asm printer, please
do some timing of llc on some reasonable file to verify that it
doesn't hurt the (non-verbose?) performance and provide that in the
commit.

I don't think it is onerous to expect changes not to cause performance
regressions. From a testing and quality control stand point, this is
just like wanting the test suite to be free of failures. The problem
is that once regressions are allowed to stand, they compound and
become much harder to analyze.

 - Daniel

>                                    -Dave
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>