[llvm-commits] [llvm] r77149 - /llvm/trunk/lib/VMCore/Value.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Sun Jul 26 04:22:02 2009
New Revision: 77149

URL: http://llvm.org/viewvc/llvm-project?rev=77149&view=rev
Log:
Make sure getName().data() is always null terminated.

Modified:
    llvm/trunk/lib/VMCore/Value.cpp

Modified: llvm/trunk/lib/VMCore/Value.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Value.cpp?rev=77149&r1=77148&r2=77149&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Value.cpp (original)
+++ llvm/trunk/lib/VMCore/Value.cpp Sun Jul 26 04:22:02 2009
@@ -152,7 +152,10 @@
 }
 
 StringRef Value::getName() const {
-  if (!Name) return StringRef();
+  // Make sure the empty string is still a C string. For historical reasons,
+  // some clients want to call .data() on the result and expect it to be null
+  // terminated.
+  if (!Name) return StringRef("", 0);
   return Name->getKey();
 }