[llvm-commits] [PATCH] Add support for promoting integer SETCC

[Eli Friedman]

On Fri, Jul 24, 2009 at 10:24 AM, Jakob Stoklund Olesen<stoklund at 2pi.dk> wrote:
>
> On 24/07/2009, at 18.43, Eli Friedman wrote:
>
>> You didn't actually change it precisely per my suggestion... you
>> should be using isOperationLegal instead of isOperationLegalOrCustom.
>
> Sorry, I wrongly assumed that was a typo =:-O
>
> If SETCC is marked "Custom", won't it be OK to create such a node at
> this point?
> Won't the custom LowerOperation() be called after SimplifySetCC() in
> that case?

By what?  Note that this is *after* operation legalization.

> Note that PowerPC and X86 have "Custom" SETCC operations, so the patch
> could be changing their behaviour.

I think this is a no-op on both platforms .X86 doesn't leave around
any SETCC/SELECT_CC/BR_CC operations after legalization. PPC doesn't
leave around any SETCC operations after legalization, and
SELECT_CC/BR_CC are legal.

-Eli