[llvm-commits] [llvm] r76558 - in /llvm/trunk: lib/CodeGen/VirtRegRewriter.cpp test/CodeGen/X86/2009-07-21-RewriterBug.ll

[Evan Cheng]

On Jul 22, 2009, at 11:48 AM, David Greene wrote:

> On Wednesday 22 July 2009 12:54, Evan Cheng wrote:
>> It's part of the test suite: 256.bzip2.
>
> Would it be possible to save the reduced testcase somewhere?  It's  
> nice not
> to have to sift through a whole application.  If the application  
> starts
> failing, it would be convenient to run the smaller testcases to see if
> there's been a regression.

In this case, I am happy not having to commit a test case. If the  
subreg coalescer starts acting up, I am sure we'll catch it with our  
regular testing.

>
> Perhaps we need a second-tier "make check" for larger testcases that  
> only
> gets run once a week or maybe just when llvm-test fails.  Would that  
> be
> helpful?

I don't think that adds a lot of value. If it's not the default,  
people will forget about it.

Evan

>
>                                     -Dave
>
>> Evan
>>
>> On Jul 22, 2009, at 8:01 AM, David Greene wrote:
>>> Bill Wendling wrote:
>>>>>>> I've fine with removing the test case.
>>>>>>
>>>>>> Ok, please do, thanks.
>>>>>
>>>>> PLEASE reconsider.  As Evan noted, register allocation bugs are
>>>>> some of the
>>>>> most subtle and difficult to track down.  Testcases are a real
>>>>> blessing.
>>>>> Better to slow down testing and get it right than ram through and
>>>>> silently
>>>>> produce wrong code.
>>>>
>>>> Is it possible to put the original application in the test-suite
>>>> instead?
>>>
>>> That sounds good to me if it can happen.
>>>
>>>                         -Dave
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits