[llvm-commits] [llvm] r76678 - in /llvm/trunk: include/llvm/CodeGen/MachineConstantPool.h lib/CodeGen/MachineFunction.cpp lib/Target/ARM/ARMConstantPoolValue.h

[Duncan Sands]

Hi Chris,
> +  /// getRelocatationInfo - This method classifies the entry according to

getRelocatationInfo -> getRelocationInfo (not just the comment, also the
function declaration).

> +  /// whether or not it may generate a relocation entry.  This must be
> +  /// conservative, so if it might codegen to a relocatable entry, it should say
> +  /// so.  The return values are:
> +  /// 
> +  ///  0: This constant pool entry is guaranteed to never have a relocation
> +  ///     applied to it (because it holds a simple constant like '4').
> +  ///  1: This entry has relocations, but the entries are guaranteed to be
> +  ///     resolvable by the static linker, so the dynamic linker will never see
> +  ///     them.
> +  ///  2: This entry may have arbitrary relocations. 

how about using an enum for this?

Ciao,

Duncan.