[llvm-commits] [llvm] r76558 - in /llvm/trunk: lib/CodeGen/VirtRegRewriter.cpp test/CodeGen/X86/2009-07-21-RewriterBug.ll

[Evan Cheng]

On Jul 21, 2009, at 3:19 PM, Chris Lattner wrote:

>
> On Jul 21, 2009, at 3:10 PM, Evan Cheng wrote:
>
>>>> I can't reduce it any further.
>>>
>>> I don't believe you.  It has tons of global variable inits etc that
>>> don't impact codegen.  Knowing the problem, can't you hand  
>>> synthesize
>>
>> Fine. I can remove some of the global variables.
>>
>>> a testcase to expose the problem?
>>
>> Trust me. It's not possible. I welcome anyone who can hand construct
>> register allocation miscompilation problems.
>
> Is the testcase worth it then?  Having regression tests is always a
> balance between catching future bugs and slowing down all testing.  If
> you add a large testcase, it becomes less interesting to have it in
> the suite.

I've fine with removing the test case.

Evan

>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits