[llvm-commits] [llvm] r76662 - /llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp

Chris Lattner sabre at nondot.org
Tue Jul 21 15:32:55 PDT 2009


Author: lattner
Date: Tue Jul 21 17:32:55 2009
New Revision: 76662

URL: http://llvm.org/viewvc/llvm-project?rev=76662&view=rev
Log:
simplify based on the fact that darwin always uses L/l.

Modified:
    llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp

Modified: llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp?rev=76662&r1=76661&r2=76662&view=diff

==============================================================================
--- llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/DarwinTargetAsmInfo.cpp Tue Jul 21 17:32:55 2009
@@ -113,15 +113,11 @@
   
   // Check whether the mangled name has the "Private" or "LinkerPrivate" prefix.
   if (GV->hasLocalLinkage() && !isa<Function>(GV)) {
+    // FIXME: ObjC metadata is currently emitted as internal symbols that have
+    // \1L and \0l prefixes on them.  Fix them to be Private/LinkerPrivate and
+    // this horrible hack can go away.
     const std::string &Name = Mang->getMangledName(GV);
-    // FIXME: Always "L" and "l", simplify!
-    const char *PGPrefix = getPrivateGlobalPrefix();
-    const char *LPGPrefix = getLinkerPrivateGlobalPrefix();
-    unsigned PGPLen = strlen(PGPrefix);
-    unsigned LPGPLen = strlen(LPGPrefix);
-
-    if ((PGPLen != 0 && Name.substr(0, PGPLen) == PGPrefix) ||
-        (LPGPLen != 0 && Name.substr(0, LPGPLen) == LPGPrefix))
+    if (Name[0] == 'L' || Name[0] == 'l')
       return false;
   }
 





More information about the llvm-commits mailing list