[llvm-commits] [PATCH] StringRef class.

[Daniel Dunbar]

On Tue, Jul 21, 2009 at 11:36 AM, Douglas Gregor<dgregor at apple.com> wrote:
>
> On Jul 21, 2009, at 10:33 AM, Daniel Dunbar wrote:
>
>> On Tue, Jul 21, 2009 at 8:04 AM, Douglas Gregor<dgregor at apple.com>
>> wrote:
>>> On Jul 20, 2009, at 5:05 PM, Daniel Dunbar wrote:
>>>> The attached patch provides a new StringRef helper class, which is
>>>> used to represent a constant string (pointer & length) which is not
>>>> owned.
>> ...
>>> One gets more uniform conversions for the left- and right-hand
>>> arguments if these are written as friend function definitions, e.g.,
>>
>> Fixed.
>>
>>> Also, for the concatenation operators, one can make them slightly
>>> more
>>> efficient with, e.g.,
>>
>> Thanks. You didn't comment on whether you thought adding them was a
>> good idea or not, though. :)
>
>
>
> I think adding the concatenation operators is a good idea.

FYI, Chris and I sketched out what I think is a nice solution to this
and other problems, patch to come...

 - Daniel