[llvm-commits] patch: mdnode .bc format change

[Devang Patel]

On Mon, Jul 20, 2009 at 10:33 PM, Nick Lewycky<nicholas at mxc.ca> wrote:

>> - Reusing ConstantPlaceHolder for Metadata is not a good idea, I've
>> doubts that this will work. ConstantPlaceHolder is meant for
>> ConstExprs.
>
> It works fine :) If you like I can refactor it into a
> MetadataPlaceHolder, but I don't see the benefit. What in particular are
> you worried about (ie. why does it matter that ConstantPlaceHolder was
> meant for ConstExprs)?

I don't think dyn_cast<MDNode>(CPH) would work where CPH is
ConstantPlaceHolder. Anyway, we are moving away from Constants from
metadata, so this is mute.

>> I am moving in a direction where metadata is not derived from
>> Constant. I will introduce new block in bitcode to hold metadata
>> strings and nodes.
>
> Okay. I assume this goes with removing the uniqueness property from MDNode?

No.
-
Devang