[llvm-commits] LLVM Verilog Backend

[Daniel Dunbar]

On Sat, Jul 18, 2009 at 3:36 PM, Eli Friedman<eli.friedman at gmail.com> wrote:
> On Sat, Jul 18, 2009 at 3:20 PM, Daniel Dunbar<daniel at zuster.org> wrote:
>> On Sat, Jul 18, 2009 at 2:34 PM, Eli Friedman<eli.friedman at gmail.com> wrote:
>>>  Also, I would recommend not indenting the
>>> contents of namespaces; it leads to a lot of extra indentation which
>>> isn't particularly useful.
>>
>> I would like to get a formal ruling on this in the style guide. Chris?
>>
>> Personally, I would like to have them always indented as it simplifies
>> pretty printing, a but I'll settle for anything consistent. Someone on
>> IRC mentioned:
>>  http://webkit.org/coding/coding-style.html
>>
>> FWIW, they follow the rule that namespaces are indented in headers but
>> not in implementation files.
>
> Oh, I see what you mean... I wasn't really considering it carefully.
> How about "always indent namespaces, don't define functions inside a
> namespace"?

Yeah, I like that rule. Small inlines functions in classes are
probably an exception, since its a lot more work to duplicate the
function declaration outside the namespace.

 - Daniel