[llvm-commits] [patch] Fix: Kaleidoscope link in JIT and Interpreter by including JIT.h and Interpreter.h

[Xerxes Rånby]

The other examples happened to include ether JIT.h or Interpreter.h so i
guess it was kind of a flux only Kaleidoscope broke.

This will probably be one of those 2.5 -> 2.6 gotchas when updating LLVM
clients.

I guess the docs/tutorial pages needs to be adjusted as well.
Perhaps add a 2.6 release note stating that one of JIT.h or
Interpreter.h has to be included if using the EngineBuilder.

Cheers and have a great day!
Xerxes

Den 2009-07-18 22:40, Reid Kleckner skrev:
> I probably introduced that bug, but I don't know how I might have
> caused it, since those headers weren't there before.  The other
> examples probably all have the same problems, so I'd update them as
> well.
>
> Reid
>
> On Sat, Jul 18, 2009 at 1:27 PM, Xerxes Rånby<xerxes at zafena.se> wrote:
>   
>> The Kaleidoscope example have been segfaulting recently since the
>> EngineBuilder have returned a nullpointer for TheExecutionEngine.
>>
>> The attached patch fixes this by including JIT.h and Interpreter.h so
>> that ExecutionEngine::JITCtor and ExecutionEngine::InterpCtor gets set
>> and actually points to the constructors for the JIT and Interpreter and
>> makes ExecutionEngine::createJIT to be linked in before used by the
>> EngineBuilder.
>>
>> Ok to commit?
>> Xerxes
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>>     
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090718/0a4c88f1/attachment.html>