[llvm-commits] [llvm] r76276 - in /llvm/trunk: bindings/ocaml/executionengine/ docs/ docs/tutorial/ examples/BrainF/ examples/Fibonacci/ examples/HowToUseJIT/ examples/Kaleidoscope/ examples/ParallelJIT/ include/llvm/ExecutionEngine/ lib/Executio

[Daniel Dunbar]

On Sat, Jul 18, 2009 at 11:57 AM, Chris Lattner<clattner at apple.com> wrote:
> On Jul 18, 2009, at 9:20 AM, Reid Kleckner wrote:
>>> Why put these in a separate namespace? Why not just make a public
>>> enum
>>> inside EngineBuilder? (I haven't been following the JIT API
>>> discussions, so ignore me if this has already been hashed out)
>>
>> I was just copying what had been done elsewhere, for example
>> CodeGenOpt::Type/Default/None/etc.  I can change it back if you like.
>
> I prefer having the namespace, it avoids name pollution of llvm:: scope.

I wasn't suggesting polluting the namespace, I was suggesting less
pollution of the namespace by putting the option inside the
EngineBuilder class. This is frequently how we write enums in clang,
and I prefer it unless the enum is used in places which aren't related
to the containing class.

 - Daniel