[llvm-commits] [llvm] r76285 - /llvm/trunk/lib/Transforms/Utils/InlineCost.cpp

[Eli Friedman]

On Fri, Jul 17, 2009 at 10:33 PM, Chris Lattner<clattner at apple.com> wrote:
>
> On Jul 17, 2009, at 10:26 PM, Eli Friedman wrote:
>
>> Author: efriedma
>> Date: Sat Jul 18 00:26:06 2009
>> New Revision: 76285
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=76285&view=rev
>> Log:
>> Fix the inline cost calculation to take into account instructions
>> which cannot be folded even if they have constant operands.
>> Significantly
>> helps if_spppsubr.c attached to PR4573.
>
> Hi Eli,
>
> This is a great catch.  However, one case that is important to get is
> "load <ptr>" where ptr is a (constant) pointer to a constant global.
> This can lead to serious shrinkage :)
>
> -Chris

It doesn't look trivial to implement, so I filed it as PR4574.

-Eli