[llvm-commits] [llvm] r75500 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/MC/MCAsmStreamer.cpp test/MC/AsmParser/directive_subsections_via_symbols.s tools/llvm-mc/AsmParser.cpp tools/llvm-mc/AsmParser.h

[Kevin Enderby]

On Jul 16, 2009, at 9:56 AM, Daniel Dunbar wrote:

> Hi Kevin,
>
> One comment:
>
> On Mon, Jul 13, 2009 at 2:03 PM, Kevin Enderby<enderby at apple.com>  
> wrote:
>> Author: enderby
>> Date: Mon Jul 13 16:03:15 2009
>> New Revision: 75500
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=75500&view=rev
>> Log:
>> add llvm-mc support for parsing the .subsections_via_symbols  
>> directive.
>>
>> Added:
>>    llvm/trunk/test/MC/AsmParser/directive_subsections_via_symbols.s
>> Modified:
>>    llvm/trunk/include/llvm/MC/MCStreamer.h
>>    llvm/trunk/lib/MC/MCAsmStreamer.cpp
>>    llvm/trunk/tools/llvm-mc/AsmParser.cpp
>>    llvm/trunk/tools/llvm-mc/AsmParser.h
>>
>> Modified: llvm/trunk/include/llvm/MC/MCStreamer.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ 
>> MC/MCStreamer.h?rev=75500&r1=75499&r2=75500&view=diff
>>
>> ===================================================================== 
>> =========
>> --- llvm/trunk/include/llvm/MC/MCStreamer.h (original)
>> +++ llvm/trunk/include/llvm/MC/MCStreamer.h Mon Jul 13 16:03:15 2009
>> @@ -89,6 +89,11 @@
>>     // symbol section in the constructor and initialize it here?
>>     virtual void EmitLabel(MCSymbol *Symbol) = 0;
>>
>> +    /// SubsectionsViaSymbols - Note in the output that the  
>> conventions used in
>> +    /// in the assembly file allows the bytes of a section to be  
>> divided up at
>> +    /// the boundaries of the symbols by a link editor for  
>> processing as atoms.
>> +    virtual void SubsectionsViaSymbols(void) = 0;
>
> I don't think we want a specific MCStreamer API for this. How about we
> just have a generic EmitAssemblerFlag API call which takes an
> enumerated constant. That way if we need another similar call we only
> have to add a new enum value.

Thanks for the direction!  Made the change and committed it just now.  
(r76087)

>
>  - Daniel