[llvm-commits] [llvm] r75790 - /llvm/trunk/include/llvm/System/Path.h

[Dan Gohman]

On Jul 15, 2009, at 9:39 AM, Chris Lattner wrote:


>
> On Jul 15, 2009, at 9:33 AM, Dan Gohman wrote:
>
>
>> Author: djg
>>
>> Date: Wed Jul 15 11:33:33 2009
>>
>> New Revision: 75790
>>
>>
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=75790&view=rev
>>
>> Log:
>>
>> Add a raw_ostream operator<< to sys::Path.
>>
>
> Is this really worthwhile?  This tightly couples sys::Path and
> raw_ostream.  Why can't the client just use toString?  The API for
> sys::Path is already significantly broken in a lot of ways, I'd like
> for it to not expand in scope.

Yes. It makes porting from std::ostream to raw_ostream easier, and
it doesn't add any additional burden to the task of refactoring  
sys::Path.

Dan