[llvm-commits] [llvm] r75619 - in /llvm/trunk/lib: CodeGen/AsmPrinter/AsmPrinter.cpp Target/DarwinTargetAsmInfo.cpp

[Dale Johannesen]

On Jul 13, 2009, at 11:27 PMPDT, Evan Cheng wrote:
> On Jul 13, 2009, at 11:21 PM, Chris Lattner wrote:
>> +  /// FIXME: WHAT IS THIS?
>> +
>>  if (GV->hasLocalLinkage() && !isa<Function>(GV) &&
>>      ((strlen(getPrivateGlobalPrefix()) != 0 &&
>> -        Mang- 
>> >getValueName(GV).substr(0,strlen(getPrivateGlobalPrefix())) ==
>> +        Mang- 
>> >getMangledName(GV).substr(0,strlen(getPrivateGlobalPrefix())) ==
>>          getPrivateGlobalPrefix()) ||
>>       (strlen(getLessPrivateGlobalPrefix()) != 0 &&
>> -        Mang- 
>> >getValueName(GV).substr(0,strlen(getLessPrivateGlobalPrefix())) ==
>> +        Mang->getMangledName(GV).substr(0,
>> +                                         
>> strlen(getLessPrivateGlobalPrefix())) ==
>>          getLessPrivateGlobalPrefix())))
>
> Dale, I think you added "less private global". Do you remember?

Only what's in the comment:
     /// LessPrivateGlobalPrefix - This prefix is used for symbols  
that should
     /// be passed through the assembler but be removed by the  
linker.  This
     /// is "l" on Darwin, currently used for some ObjC metadata.