[llvm-commits] Adding a builder for ExecutionEngines

[Reid Kleckner]

On Sat, Jul 11, 2009 at 9:28 AM, Reid Kleckner<rnk at mit.edu> wrote:
> On Fri, Jul 10, 2009 at 2:53 PM, Eric Christopher<echristo at apple.com> wrote:
>>
>> On Jul 8, 2009, at 4:35 PM, Reid Kleckner wrote:
>>
>>> In the last patch I was working on, Evan asked if I could add a
>>> builder for ExecutionEngines, since the current API call is kind of
>>> unwieldy.  It has four optional arguments, and a fifth if you count
>>> the JIT memory manager.  I attempted to unify this all into just one
>>> EngineBuilder class, which makes it so you only have to specify the
>>> arguments you want to control with chained setter methods.
>>>
>>> Does this seem like a better API?  Please review.
>>
>> I definitely like the idea, any hope of getting a patch after
>> Jeffrey's comments?
>
> Yes, it's still alive, I've just been busy all week with the two other
> patches I have cooking for improving the memory manager and the
> GDB/JIT interface.

I updated uses of the old API to use the builder instead.  Is that OK?
 Please review.

Thanks,
Reid
-------------- next part --------------
A non-text attachment was scrubbed...
Name: EngineBuilderPatch.diff
Type: text/x-diff
Size: 28385 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090713/03602eec/attachment.diff>