[llvm-commits] [llvm] r75261 - /llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll

[Chris Lattner]

On Jul 11, 2009, at 8:40 PM, Daniel Dunbar wrote:
> This looks nice, but one thing it is missing which was checked before
> was that there was, e.g. exactly one moveq line. Have you thought
> about how to add that to FileCheck?

Not really.  It also doesn't handle checks for "ensure this  
instruction never exists in the file".  It would be straight-forward  
to add this sort of thing, but its not clear to me that it is  
valuable.  This file, for example, only has one reasonable sequence of  
instructions to generate, so testing that exactly the right thing is  
generated by each function should be enough.

-Chris

>
> - Daniel
>
> On Fri, Jul 10, 2009 at 11:34 AM, Chris Lattner<sabre at nondot.org>  
> wrote:
>> Author: lattner
>> Date: Fri Jul 10 13:34:47 2009
>> New Revision: 75261
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=75261&view=rev
>> Log:
>> convert test to use FileCheck, which is much more precise and  
>> faster than
>> the previous RUN lines.  Hopefully this will be an inspiration for  
>> future
>> tests :)
>>
>> Modified:
>>    llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll
>>
>> Modified: llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll?rev=75261&r1=75260&r2=75261&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll (original)
>> +++ llvm/trunk/test/CodeGen/Thumb2/thumb2-select.ll Fri Jul 10  
>> 13:34:47 2009
>> @@ -1,13 +1,11 @@
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep moveq  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep movgt  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep movlt  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep movle  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep movls  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep movhi  
>> | count 1
>> -; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | grep it     
>> | count 6
>> +; RUN: llvm-as < %s | llc -march=thumb -mattr=+thumb2 | FileCheck %s
>>
>>  define i32 @f1(i32 %a.s) {
>>  entry:
>> +; CHECK: f1:
>> +; CHECK: it eq
>> +; CHECK: moveq
>> +
>>     %tmp = icmp eq i32 %a.s, 4
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>> @@ -15,6 +13,9 @@
>>
>>  define i32 @f2(i32 %a.s) {
>>  entry:
>> +; CHECK: f2:
>> +; CHECK: it gt
>> +; CHECK: movgt
>>     %tmp = icmp sgt i32 %a.s, 4
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>> @@ -22,6 +23,9 @@
>>
>>  define i32 @f3(i32 %a.s, i32 %b.s) {
>>  entry:
>> +; CHECK: f3:
>> +; CHECK: it lt
>> +; CHECK: movlt
>>     %tmp = icmp slt i32 %a.s, %b.s
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>> @@ -29,6 +33,10 @@
>>
>>  define i32 @f4(i32 %a.s, i32 %b.s) {
>>  entry:
>> +; CHECK: f4:
>> +; CHECK: it le
>> +; CHECK: movle
>> +
>>     %tmp = icmp sle i32 %a.s, %b.s
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>> @@ -36,6 +44,9 @@
>>
>>  define i32 @f5(i32 %a.u, i32 %b.u) {
>>  entry:
>> +; CHECK: f5:
>> +; CHECK: it ls
>> +; CHECK: movls
>>     %tmp = icmp ule i32 %a.u, %b.u
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>> @@ -43,6 +54,9 @@
>>
>>  define i32 @f6(i32 %a.u, i32 %b.u) {
>>  entry:
>> +; CHECK: f6:
>> +; CHECK: it hi
>> +; CHECK: movhi
>>     %tmp = icmp ugt i32 %a.u, %b.u
>>     %tmp1.s = select i1 %tmp, i32 2, i32 3
>>     ret i32 %tmp1.s
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits