[llvm-commits] [llvm] r75199 - in /llvm/trunk: include/llvm/Support/raw_ostream.h lib/Support/raw_ostream.cpp

Dan Gohman gohman at apple.com
Thu Jul 9 16:58:46 PDT 2009


On Jul 9, 2009, at 4:43 PM, David Greene wrote:

> void raw_ostream::flush_nonempty() {
>   assert(OutBufCur > OutBufStart && "Invalid call to  
> flush_nonempty.");
> +  AboutToFlush();
>   write_impl(OutBufStart, OutBufCur - OutBufStart);

Instead of introducing a new hook and making flush_nonempty make two  
virtual
calls, could you make AsmOStream override write_impl to do its work, and
then call its superclass' write_impl?

Dan




More information about the llvm-commits mailing list