[llvm-commits] [cfe-commits] r74986 - in /cfe/trunk/lib/CodeGen: CGBlocks.cpp CGCXX.cpp CGDecl.cpp CGExprConstant.cpp CGObjCGNU.cpp CGObjCMac.cpp CodeGenModule.cpp

[Chris Lattner]

On Jul 8, 2009, at 8:48 AM, Owen Anderson wrote:
> On Jul 7, 2009, at 11:08 PM, Chris Lattner wrote:
> On Jul 7, 2009, at 6:29 PM, Owen Anderson wrote:
>>> Author: resistor
>>> Date: Tue Jul  7 20:29:18 2009
>>> New Revision: 74986
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=74986&view=rev
>>> Log:
>>> Update for LLVM API change.
>>
>> Hi Owen,
>>
>> Why do you need to specify a context to the globalvariable ctor  
>> when you also specify a module?
>
> Because the Module is optional, and we use this when building the GV  
> sentinels.

Why not have two different methods, one that requires a context, and  
one that requires a module?  Alternatively,  why not just make the  
existing method require a module, and add a method on context for  
making a GV without a module?

-Chris