[llvm-commits] [llvm] r74879 - /llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp

[Devang Patel]

Author: dpatel
Date: Mon Jul  6 18:11:08 2009
New Revision: 74879

URL: http://llvm.org/viewvc/llvm-project?rev=74879&view=rev
Log:
Add FIXMEs.

Modified:
    llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp

Modified: llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp?rev=74879&r1=74878&r2=74879&view=diff

==============================================================================
--- llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp (original)
+++ llvm/trunk/lib/Target/PIC16/PIC16DebugInfo.cpp Mon Jul  6 18:11:08 2009
@@ -200,6 +200,7 @@
 /// required initializations.
 void PIC16DbgInfo::BeginModule(Module &M) {
   // Emit file directive for module.
+  // FIXME : What if more then one CUs are present in a module ?
   GlobalVariable *CU = M.getNamedGlobal("llvm.dbg.compile_unit");
   if (CU) {
     EmitDebugDirectives = true;
@@ -321,6 +322,7 @@
       E = M.getGlobalList().end(); I != E; I++) {
     // Structures and union declaration's debug info has llvm.dbg.composite
     // in its name.
+    // FIXME: Checking and relying on llvm.dbg.composite name is not a good idea.
     if(I->getName().find("llvm.dbg.composite") != std::string::npos) {
       GlobalVariable *GV = cast<GlobalVariable >(I);
       DICompositeType CTy(GV);
@@ -425,6 +427,7 @@
 /// EmitVarDebugInfo - Emit debug information for all variables.
 ///
 void PIC16DbgInfo::EmitVarDebugInfo(Module &M) {
+  // FIXME : This anchor has been removed.
   GlobalVariable *Root = M.getGlobalVariable("llvm.dbg.global_variables");
   if (!Root)
     return;