[llvm-commits] [llvm] r74624 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/Target/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/CellSPU/ lib/Target/IA64/ lib/Target/MSP430/ lib/Target/Mips/ lib/Target/PIC16/ lib/Target/PowerPC/ lib/Target/

Duncan Sands baldrick at free.fr
Thu Jul 2 05:03:41 PDT 2009

Hi Chris,

> I vote for keeping it in log2 and standardizing on log2 form.  The  
> reason is that it takes less space to represent, it is impossible to  
> store something that is not a pow2, and it is cheaper to convert from  
> log2 -> bytes than from bytes->log2.

several places already secretly store alignment internally in log2 form,
but provide it in bytes to users.  I like this scheme.  Since alignments
are typically only stored once but read many times, I doubt there's any
worry about the cost of the initial bytes -> log2 conversion when the
alignment is first initialized.



More information about the llvm-commits mailing list