[llvm-commits] [llvm] r74450 - in /llvm/trunk/tools/llvm-mc: AsmExpr.cpp AsmExpr.h

[Chris Lattner]

On Jul 1, 2009, at 12:08 AM, Daniel Dunbar wrote:

>>> URL: http://llvm.org/viewvc/llvm-project?rev=74450&view=rev
>>> Log:
>>> MC: Improve expression parsing and implement evaluation of absolute
>>> expressions
>>> (missed files).
>>
>> Nice, can you add some doxygen comments to the new classes etc  
>> though?
>
> Sure. Is there something in particular you think is missing, I'll add
> class level comments but I think most of the uncommented methods are
> obvious from the name and context. We don't have an official style
> position on this, but in clang at least we frequently don't have
> doxygen comments for trivial methods.

Right, class level comments + comments on important ivars should be  
enough, thanks!

-Chris