[llvm-commits] [PATCH] Improve error handling, supersede cerr+abort

[Chris Lattner]

On Jun 30, 2009, at 9:59 PM, Eli Friedman wrote:

> On Tue, Jun 30, 2009 at 9:28 PM, Chris Lattner<clattner at apple.com>  
> wrote:
>> I think that this is over-designed.  The depths of the code generator
>> should not be producing warnings, ever.
>
> Instcombine currently can produce warnings; are you suggesting we
> should get rid of that?

Yes, without loc info, it is pretty useless.  Working with end users  
using llvm-gcc, every time they get that warning, they assume it is a  
bug in the compiler, not a bug in their code.

>> We don't need this.  Assertions "can't happen", so assert(0) really  
>> is
>> unreachable.
>
> Mmm... yeah; that said, I think there are places where we should turn
> assertions into errors (particularly in legalization).

Yes, I agree.  Also the "cannot select" error should also be handled  
as an error not assert.

-Chris