[llvm-commits] [LLVMdev] Removing std::vector from APIs

Chris Lattner clattner at apple.com
Tue Jun 30 21:14:36 PDT 2009

On May 26, 2009, at 6:54 AM, Jay Foad wrote:

> 2009/5/14 Chris Lattner <clattner at apple.com>:
>> One minor thing is that StructType::get(NULL, 0) looks somewhat  
>> strange to
>> me.  How about adding a zero-argument version of "get" that returns  
>> the
>> empty struct?  That would allow code to use StructType::get().
> How about this? It adds:
> FunctionType *FunctionType::get(const Type *Result, bool isVarArg);
> StructType *StructType::get(bool isPacked = false);
> .. although the latter isn't used much because I've preferred to use
> Type::EmptyStructTy instead.
> It passes "make check", cfe's "make test", and llvm-gcc still  
> bootstraps.

Looks great, applied here, sorry for the delay!


More information about the llvm-commits mailing list