[llvm-commits] SSI patch

[Andre Tavares]

Hello Bruno,

Bruno Cardoso Lopes wrote:
> Hi Andre,
>
> On Thu, Jun 25, 2009 at 9:59 AM, Andre Tavares<andrelct at dcc.ufmg.br> wrote:
>   
>> Hello,
>>
>> I'm submiting a patch that will be responsible to create SSI representation
>> on demand. This representation conforms with the current SSA, and will not
>> break other optimizations. It only inserts some phi functions on the code. A
>> brief description is below, and the code is attached.
>>
>> // This pass converts a list of variables to the Static Single Information
>> // form. This is a program representation described by Scott Ananian in his
>> // Master Thesis: "The Static Single Information Form (1999)".
>> // We are building an on-demand representation, that is, we do not convert
>> // every single variable in the target function to SSI form. Rather, we
>> receive
>> // a list of target variables that must be converted. We also do not
>> // completely convert a target variable to the SSI format. Instead, we only
>> // change the variable in the points where new information can be attached
>> // to its live range, that is, at branch points.
>>     
>
> Just some coding style comments, lines not within 80 columns:
>
> SSI_And.cpp
> 78: /// Insert sigma functions (a sigma function is a phi function
> with one operator)
> 236:   for (DomTreeNode::iterator begin = DTN->begin(); begin !=
> DTN->end(); ++begin) {
> 253: /// Substitute any use in this instruction for the last
> definition of the variable
> SSI_And.h
> 23: // (either it has virtual methods or it derives from classes with
> virtual methods),
>
>   
I tried to stay within the 80 columns, but it seams you got me there. 
Fixed it.

Thanks

-- 
Andre Tavares
Master Student in Computer Science - UFMG - Brasil
http://dcc.ufmg.br/~andrelct